[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 18:43:04 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64580


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-07-14 18:43:05 PST ---
Attachment 100911 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/html/HTMLAnchorElement.cpp'..." exit_code: 1

Source/WebCore/html/HTMLAnchorElement.h:118:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/FrameLoader.h:111:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebCore/loader/FrameLoader.h:348:  The parameter name "sourceRequest" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/FrameLoader.h:348:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebCore/loader/FrameLoader.cpp:268:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 5 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list