[Webkit-unassigned] [Bug 39578] IME: no underline is shown when entering Japanese preedit text in an input box on QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39578





--- Comment #12 from Tasuku Suzuki <tasuku.suzuki at nokia.com>  2011-07-14 18:21:03 PST ---
(In reply to comment #10)
> (From update of attachment 99267 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99267&action=review
> 
> You do not explain how this patch solve the original problem. I wonder if we can solve the bug without the save()/restore().
> 
> The change looks sane but I am not convinced that is the best solution. Saving and restoring state is not cheap. In the general usage of RenderObject::drawLineForBoxSide(), the state varies actually very little between calls so the rendering is effective even on OpenGL graphic system.

The patch doesn't seem to solve the original problem directly. But when I commented out a line below, underline was drawn correctly. This is why I added save()/restore() in the method.
// graphicsContext->setStrokeStyle(NoStroke);

Do you think to reset the stroke style manually would be better?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.