[Webkit-unassigned] [Bug 61978] --webkit-visual-word crash on mixed editability

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61978


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100892|review?                     |review+
               Flag|                            |




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2011-07-14 16:43:43 PST ---
(From update of attachment 100892)
View in context: https://bugs.webkit.org/attachment.cgi?id=100892&action=review

> Source/WebCore/ChangeLog:3
> +        Fix 2 --webkit-visual-word crashes:

Nit: we don't usually have this.

> Source/WebCore/ChangeLog:19
> +        Check previousBoundary/nextBoundary against NULL.
> +
> +        Have a static function to encapsulate the usage of getInlineBoxAndOffset and check the 
> +        visible position is not NULL before passing to getInlineBoxAndOffset.
> +
> +        Check the box returned from getInlineBoxAndOffset is not NULL before accessing.

Can we combine these into one paragraph?  I feel like it's scattered.

> LayoutTests/editing/selection/move-by-word-visually-null-box.html:13
> +        document.body.innerHTML = "Test Passed";

Maybe you should say "Crash test passed" instead to make it clear that this is a crash test?

> LayoutTests/platform/qt/Skipped:2486
> +editing/selection/move-by-word-visually-null-box.html

Why this is test skilled in Qt?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.