[Webkit-unassigned] [Bug 60529] Programmatically set selection should not have direction on Mac

Thu Jul 14 16:41:03 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=60529

Wyatt Carss <wcarss at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100869|review?                     |
               Flag|                            |

--- Comment #22 from Wyatt Carss <wcarss at chromium.org>  2011-07-14 16:41:03 PST ---
(From update of attachment 100869)
View in context: https://bugs.webkit.org/attachment.cgi?id=100869&action=review

>> LayoutTests/editing/selection/programmatic-selection-on-mac-is-directionless.html:81
>> +    allPlatformsAreBackward = 'backward';
> 
> Ditto.  Also, I don't see any benefit in having these variables around.  It only bloats the code as far as I can tell.

Using the full object notation on every line makes the lines very hard to read. these variables seemed like a good way to compress the size and increase readability. Perhaps I could try "expectForwardOnAllPlatforms" and "expectBackwardOnMacAndForwardOnUnixAndWin"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.