[Webkit-unassigned] [Bug 55257] Support creating compositing layers for scrollable frames and iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55257





--- Comment #45 from Daniel Sievers <sievers at chromium.org>  2011-07-14 15:49:24 PST ---
> > Source/WebCore/page/FrameView.cpp:948
> > +        if (root->view()->document()->frame()->tree()->parent())
> 
> There has to be a better way than root->view()->document()->frame()->tree()->parent()

Done.

> 
> > Source/WebCore/page/FrameView.cpp:949
> > +            compositor->setForceCompositingMode(compositor->requiresCompositingForScrollableFrame(view) ? true : false);
> 
> No need for foo ? true : false.
> 

Done.

> Also, this could be just one method on the compositor: compositor->forceCompostingForScrollableFrame().
> 

Done.

> So you want scrollable frames to composite even if nothing else is triggering composting mode? Why not just always use compositing?

Yes, I wanted it separate. Also the 'force compositing' setting only forces it on the root layer but not on frame/child compositors.

> 
> > Source/WebCore/page/Settings.h:313
> > +        void setAcceleratedCompositingForScrollableFrameEnabled(bool);
> > +        bool acceleratedCompositingForScrollableFrameEnabled() const { return m_acceleratedCompositingForScrollableFrameEnabled; }
> 
> I'd name these acceleratedCompositingForScrollableFrame_s_Enabled
> 

Done.

> I don't really like the fact that you're adding a setting. Will this get toggled at runtime? Can it just be a compile-time thing?
> 

At runtime would be nice to be able to support a cmdline flag.
Also, I tried to mimick the other compositing triggers which have similar settings.

> > Source/WebCore/rendering/RenderLayerCompositor.cpp:1278
> > +    if (!ownerElement || (!ownerElement->hasTagName(iframeTag) && !ownerElement->hasTagName(frameTag)))
> > +        return false;
> 
> What about <object src="foo.html">?

Maybe handle separately?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.