[Webkit-unassigned] [Bug 63381] [GTK] [WK2] Implement missing initializeLogChannel function.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63381





--- Comment #7 from Lukasz Slachciak <l.slachciak at samsung.com>  2011-07-14 14:22:56 PST ---
(From update of attachment 99293)
View in context: https://bugs.webkit.org/attachment.cgi?id=99293&action=review

>> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:39
>> +    static Vector<String> logv;
> 
> Please don't use abbreviations for variable names. I suggest something like activatedChannels here, instead of logv.

done

>> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:52
>> +    }
> 
> Instead of iterating and parsing log channel names for every single channel, why not build a Vector of WTFLogChannel once and then simply do activatedChannels.contains each time? This would take up less space and be faster, I believe.

Yes you are right. Code will be little more complicated now, but faster. No need to iterate each time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.