[Webkit-unassigned] [Bug 64549] Remove LegacyDefaultOptionalArguments flag from WebGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64549


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100844|review?                     |review-
               Flag|                            |




--- Comment #3 from Kenneth Russell <kbr at google.com>  2011-07-14 13:53:02 PST ---
(From update of attachment 100844)
View in context: https://bugs.webkit.org/attachment.cgi?id=100844&action=review

Generally looks good but needs a little more work on the test changes.

> LayoutTests/fast/canvas/webgl/bad-arguments-test.html:62
> +  if (argument == undefined) {
> +    shouldThrow("context.attachShader(argument)");
> +  } else {
> +    func("context.attachShader(argument)");
> +  }

It looks like this was fixed upstream in the Khronos repository, but differently. Could you please copy the associated code from https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/bad-arguments-test.html ?

> LayoutTests/fast/canvas/webgl/context-lost.html:136
> +        "gl.blendFunc(gl.ONE, gl.ONE)",
> +        "gl.blendFuncSeparate(gl.ONE, gl.ONE, gl.ONE, gl.ONE)",

Thanks for fixing this one. I've copied this fix into the Khronos repository.

> LayoutTests/fast/canvas/webgl/null-object-behaviour.html:-25
> -shouldGenerateGLError(context, context.INVALID_VALUE, "context.compileShader()");
> -shouldGenerateGLError(context, context.INVALID_VALUE, "context.linkProgram()");
> -shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader()");

It looks like these have been fixed upstream, but differently. Could you please copy the associated code from https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/null-object-behaviour.html ?

> LayoutTests/fast/canvas/webgl/null-object-behaviour.html:-30
> -shouldGenerateGLError(context, context.INVALID_VALUE, "context.shaderSource()");

Same problem here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.