[Webkit-unassigned] [Bug 64468] DumpRenderTree hangs when run under new-run-webkit-tests on Apple's Windows port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 12:51:03 PDT 2011


--- Comment #7 from Dirk Pranke <dpranke at chromium.org>  2011-07-14 12:51:02 PST ---
(In reply to comment #5)
> Note that abspath_for_test isn't sufficient on Windows because it will produce a Cygwin-style path.
> The bare-minimum required change is here:
> http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py?rev=90826#L465
> Changing this:
> command = uri[7:] if uri.startswith("file:///") else uri
> to this:
> command = cygpath(urllib.unquote(uri[7:])) if uri.startswith("file:///") else uri
> This is a bit icky, of course, since we're converting to a URL then back to a path (but the code already does this). I think the urllib.unquote call is actually the right thing to do on all platforms if we keep this test name -> URL -> file path approach. Only the cygpath() call is Windows-specific.

There's no reason to go through the URL if you don't need to. You could just as easily change command_From_driver_input() to something like:

if driver_input.test_name.startswith('http/'):
  command = self.test_to_uri(driver_input.test_name)
  command = cygpath(self.abspath_for_test(driver_input.test_name)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list