[Webkit-unassigned] [Bug 64471] editing tests fail when run with new-run-webkit-tests on Apple's Windows port (because editing delegate callbacks aren't stripped)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 07:37:13 PDT 2011


--- Comment #3 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-14 07:37:13 PST ---
(In reply to comment #2)
> Is this only a hack for Apple Win, or do other ports want to use it?

ORWT exposes a --[no-]strip-editing-callbacks, which defaults to true on Apple's Windows port. I don't know if anyone else uses that option.

> Port already has a compare_text method, which we could override in the WinPort to do this special compare, but then the "expected" results spit out would still have the editing callbacks. (are they supposed to?)

In ORWT, the expected results still contain editing callbacks (unless the expected results were generated on Windows, of course). This is a little confusing when looking at diffs, but of course removing the editing callbacks from the expected output would also be confusing.

I think either way is fine, but matching ORWT is probably a teensy bit better.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list