[Webkit-unassigned] [Bug 63966] [EFL] Add url bar to EWebLauncher.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63966





--- Comment #20 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-07-14 07:24:04 PST ---
Still r-, as some concerns have not been addressed yet. The EDC still looks too big for my taste 

> Tools/CMakeListsEfl.txt:65
> +ADD_CUSTOM_TARGET(entry.edj

This target name still rubs me in a wrong way. What if you do what Source/WebKit/efl/CMakeListsEfl.txt does and use ADD_CUSTOM_COMMAND with the proper dependencies instead of using this? If it doesn't work, please use a more specific name, such as "Programs/EWebLauncher_theme".

> Tools/EWebLauncher/entry.edc:32
> +            base: "font=Roman font_size=16 color="ENTRY_TEXT_COLOR_INC" wrap=mixed";

The font size here is still 16.

> Tools/EWebLauncher/main.c:705
> +                full_url[len] = '\0';

I don't understand why you are doing this, as this is the faulty call which causes some bad memory management issues that I described in my previous review.

If you set the MALLOC_CHECK_ environment variable to 3, run EWebLauncher and go to "webkit.org" (without the "http://" before), the program will crash.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.