[Webkit-unassigned] [Bug 60529] Programmatically set selection should not have direction on Mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 13 20:30:15 PDT 2011


--- Comment #13 from Wyatt Carss <wcarss at chromium.org>  2011-07-13 20:30:15 PST ---
(From update of attachment 100760)
View in context: https://bugs.webkit.org/attachment.cgi?id=100760&action=review

> LayoutTests/ChangeLog:10
> +        text-input fields, and textareas.

I still intend to add undo tests, but as said previously, I'm waiting until these are in a good state.

> LayoutTests/editing/selection/programmatic-selection-on-mac-is-directionless-1.html:67
> +    runTestAndVerify(currentNode, makeTest('left', 'line'), macIsBackwardWinAndUnixAreForward, expectedResult[currentPlatform]);

This seemed unwieldy to shove into a single long line, but I'm not sure if it would be preferred that way.

> LayoutTests/editing/selection/programmatic-selection-on-mac-is-directionless-1.html:76
> +    runTestsOn(platform, document.getElementById('editable-div'));

I started off with a node-travesal like so:

for(i = 0; i < 2; i++)
    runTestsOn(platform, document.getElementById('test').children[i];

but it gave me a wacky syntax error the second time through, complaining about '1' as a property to undefined. I messed with it for 15 minutes and opted for explicitly showing the two tags instead. It's the same number of lines and similarly clear what's going on, but if you'd like me to look into the for loop solution, I'll try harder at it :P

> LayoutTests/editing/selection/programmatic-selection-on-mac-is-directionless-2-expected.txt:14
> +PASS right by line in text-input

is this sufficient output? I feel like I'm not saying enough..

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list