[Webkit-unassigned] [Bug 64493] GC allocation fast path has too many operations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64493





--- Comment #13 from Filip Pizlo <fpizlo at apple.com>  2011-07-13 19:21:30 PST ---
(In reply to comment #10)

Darin - thanks for catching those issues!  To answer your point about the free list construction policy:

> > Source/JavaScriptCore/heap/MarkedBlock.cpp:93
> > +            result = freeCell;
> 
> Is the “loop through all cells, but return the last freed one” policy here intentional? I think this is something that deserves a comment, because it’s not obvious to me at least.

It's not intentional; as far as I can tell it makes no difference if the free list is constructed in a way that makes it travel forward through the block, or backward; and I just chose the latter.  I can add a comment that explains this, or I'd be happy to construct a list that is in-order if that is more intuitive.

-Filip

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.