[Webkit-unassigned] [Bug 64474] Make GestureRecognizerChromium aware of Frame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 13 13:30:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64474





--- Comment #4 from Varun Jain <varunjain at chromium.org>  2011-07-13 13:30:25 PST ---
(In reply to comment #3)
> (From update of attachment 100696 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100696&action=review
> 
> > Source/WebCore/platform/PlatformGestureRecognizer.h:59
> > -    virtual bool processTouchEventForGesture(const PlatformTouchEvent&, EventHandler*, bool handled) = 0;
> > +    virtual bool processTouchEventForGesture(const PlatformTouchEvent&, Frame*, bool handled) = 0;
> 
> Code in WebCore/platform cannot be aware of anything in WebCore outside WebCore/platform.  That means both EventHandler and Frame are forbidden.

Hi Adam, I am not sure I understand.. there are already plenty of classes in WebCore/platform using Frame (See WebCore/platform/DragData.h, DragImage.h, PasteBoard.h for example). Are all these incorrect?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list