[Webkit-unassigned] [Bug 64444] [CSSRegions]Parse -webkit-region-overflow property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64444


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100672|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Dave Hyatt <hyatt at apple.com>  2011-07-13 11:33:32 PST ---
(From update of attachment 100672)
View in context: https://bugs.webkit.org/attachment.cgi?id=100672&action=review

Minor nits with the enum.

> Source/WebCore/css/CSSPrimitiveValueMappings.h:1358
> +    switch (m_value.ident) {

Fix the style issues with the switch statements here.

> Source/WebCore/rendering/style/RenderStyleConstants.h:441
> +#if ENABLE(CSS_REGIONS)
> +enum ERegionOverflow { ROAuto, ROBreak };
> +#endif

This is really an obsolete style that we haven't gotten around to eliminating. Just do this instead:

enum RegionOverflow { AutoRegionOverflow, BreakRegionOverflow };

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.