[Webkit-unassigned] [Bug 63897] [CSSRegions] Parse -webkit-content-order property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63897


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100290|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Dave Hyatt <hyatt at apple.com>  2011-07-13 11:28:03 PST ---
(From update of attachment 100290)
View in context: https://bugs.webkit.org/attachment.cgi?id=100290&action=review

Looks good, although I'd like to see a large index test and the added clamping, since this is so similar to z-index. I want to make sure we have the same clamping protection in place.

> Source/WebCore/css/CSSStyleSelector.cpp:4897
> +    case CSSPropertyWebkitContentOrder:
> +        HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(regionIndex, RegionIndex);
> +        return;

I think since this is so similar to z-index, we'll need to worry about people using ridiculously large content-order values. You should take a look at the z-index handling in CSSStyleSelector.cpp and mimic it. In particular I think you need a clampToInteger call.

m_style->setZIndex(clampToInteger(primitiveValue->getDoubleValue()));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.