[Webkit-unassigned] [Bug 64355] [Soup] Cannot override default max-conns and max-conns-per-host Soup Session settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64355





--- Comment #10 from Sergio Villar Senin <svillar at igalia.com>  2011-07-13 09:47:29 PST ---
(In reply to comment #9)
> This looks pretty good to me. I'd like Sergio to give it a look, just to double-check though.

The change looks sane but we would be breaking the contract of webkit_get_default_session(). With the current code you could do things like:

session = webkit_get_default_session();
soup_session_add_feature(session, my_cookie_jar);

If you do this before any request, then webkitgtk+ will use my_cookie_jar instead of the default.

But, with this patch, after webkit_get_default_session() you will get a SoupSession with a default CookieJar and a default SoupRequester among other things. It's true that you still could remove them and add yours but I think this could be considered an API break.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.