[Webkit-unassigned] [Bug 55046] Share VFP detection for ARM in MacroAssemblerARMCommon class

Tue Jul 12 23:31:50 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=55046

Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100105|review?                     |review-
               Flag|                            |

--- Comment #9 from Gavin Barraclough <barraclough at apple.com>  2011-07-12 23:31:50 PST ---
(From update of attachment 100105)
Hi xan, this patch is going to add unnecessary dynamic checks on GGC/__VFP_FP__ and RVCT/__TARGET_FPU_VFP platforms, so I'd like to suggest the following:

1) remove s_isVFPPresent for non-LINUX platforms.

2) define isVFPPresent() for non-LINUX platforms as ALWAYS_INLINE & returning a constant true/false, so that these checks can be compile out.

3) for linux only, define isVFPPresent() to return the value of s_isVFPPresent.

Hope this sounds good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.