[Webkit-unassigned] [Bug 55158] Use VFP for double to int truncate in ARMv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55158


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91715|review?                     |review+
               Flag|                            |




--- Comment #15 from Gavin Barraclough <barraclough at apple.com>  2011-07-12 23:17:02 PST ---
(From update of attachment 91715)
View in context: https://bugs.webkit.org/attachment.cgi?id=91715&action=review

Looks great xan.

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:676
> +        m_assembler.sub_S(dataTempRegister, dest, ARMThumbImmediate::makeEncodedImm(0x80000000));

Perhaps we should change the signature of this method to take a JumpList, to avoid the branch-EQ to branch-EQ.  Still, this is a second order issue to getting branchTruncateDoubleToInt32 doing anything at all!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.