[Webkit-unassigned] [Bug 64360] Move useRepaintBounds from RenderBlock::layoutRunsAndFloats to LineLayoutState

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 23:09:09 PDT 2011


--- Comment #4 from Chiculita Alexandru <achicu at adobe.com>  2011-07-12 23:09:09 PST ---
(From update of attachment 100483)
View in context: https://bugs.webkit.org/attachment.cgi?id=100483&action=review

Thanks for the review!

>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:853
>> +    bool useRepaintBounds() const { return m_useRepaintBounds; }
> "uses" or "shouldUse"? (I know original variable name was wrong....)


>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:-1293
>> -                    if (!useRepaintBounds)
> Could you elaborate why we don't need this?

Every time the updateRepaintRangeFromBox was called there was an if (!useRepaintBounds) useRepaintBounds = true. So I've moved it to updateRepaintRangeFromBox and removed the if clause. It should be faster to just update it every time than to check it and update only if needed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list