[Webkit-unassigned] [Bug 64433] New: Improve names of some ApplicationCacheStorage accessor methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64433

           Summary: Improve names of some ApplicationCacheStorage accessor
                    methods
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org


In an earlier patch review Alexey mentioned:

> > Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:827
> > +        // Failed to determine what is left in the quota. Fallback to allowing anything. 
> 
> It's a bad coding style violation that a function called remainingSizeForOriginExcludingCache()
> returns a boolean, not the remaining size. This is a pre-existing issue, and not something you
> did in this patch.

There are a few functions that should be updated:

  quotaForOrigin, usageForOrigin, and remainingSizeForOriginExcludingCache

I'll fix them with the suggested rename calculate...()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.