[Webkit-unassigned] [Bug 63674] Get webkit to compile with USE(CFNETWORK) enabled on Mac

Tue Jul 12 13:48:09 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=63674

--- Comment #10 from Pratik Solanki <psolanki at apple.com>  2011-07-12 13:48:09 PST ---
(From update of attachment 99195)
View in context: https://bugs.webkit.org/attachment.cgi?id=99195&action=review

>>>>> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:220

>>>> 
>>>> This seemed like a change in behavior to until I looked in ResourceHandleMac.mm and saw the NSURLResponse version of this code. A note in the ChangeLog about why this was added would have cleared this up.
>>> 
>>> It'd be even nicer to share this with the Mac rather than duplicating it. The Mac port could do this in terms of CF API and toll-free bridging should ensure that the NSURLResponse has the right changes.
>> 
>> Yes thats a good idea. I can refactor the code so its shared between the two implementations.
> 
> Make sure NSURLResponse is toll-free-bridged to CFURLResponse.  Not all of the NSURL* types are toll-free-bridged.

NSURLResponse is not toll-free bridged to CFURLResponse. But you can extract a CFURLResponse from an NSURLResponse and use that. I don't think I'll be able to refactor this since the CF code uses SPI in private headers thats not exposed on Mac headers (e.g. _CFURLRequestCopyProtocolPropertyForKey). Those calls would need to go through WKSI. That work is tracked by bug 63569. I did realize that I can use wk equivalents for CFURLResponseGetHTTPResponse and CFURLResponseSetMIMEType, so I'll do that. Meanwhile, I'll put in a comment in the Changelog as Andy suggested. Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.