[Webkit-unassigned] [Bug 64355] [Soup] Cannot override default max-conns and max-conns-per-host Soup Session settings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 13:21:34 PDT 2011


--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-07-12 13:21:34 PST ---
(From update of attachment 100542)
View in context: https://bugs.webkit.org/attachment.cgi?id=100542&action=review

Sorry for the confusion. Comments below.

> Source/WebCore/ChangeLog:2
> +2011-07-12  ./Source/WebCore/ChangeLog  <marco at peereboom.us>
> +

This line should list your name. I'm not sure what went wrong here.

> Source/WebCore/ChangeLog:7
> +        Default max-conns and max-conns-per-host are set at "first contact" with
> +        a site instead of at creation time.  This results in values being
> +        overwritten if they are set prior to said "first contact"; which is the
> +        most likely (or only) scenario.
> +        https://bugs.webkit.org/show_bug.cgi?id=64355

The format should actually be:

<bug title>
<bug URL>

<reviewer -- OOPS is fine here, the tools will take care of it>

<change description>

> Source/WebCore/ChangeLog:12
> +        Rigged libsoup and xxxterm web browser to diagnose the issue and
> +        validate the patch.

Here you should preserve "No new tests." and then followed by a description of why tests were not added to the WebKit repository itself.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list