[Webkit-unassigned] [Bug 64355] max-conns and max-conns-per-host not honored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64355


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100492|                            |review-
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-07-12 10:27:26 PST ---
(From update of attachment 100492)
View in context: https://bugs.webkit.org/attachment.cgi?id=100492&action=review

Seems like a decent change, but please touch up the ChangeLog a bit.

> Source/WebCore/ChangeLog:6
> +        max-conns and max-conns-per-host not honored
> +        https://bugs.webkit.org/show_bug.cgi?id=64355
> +
> +        Reviewed by NOBODY (OOPS!).

I think this change deserves a line or two explaining what problem this fixes.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You should either add a test or explain here why you didn't.

> Source/WebCore/ChangeLog:12
> +        * platform/network/soup/ResourceHandleSoup.cpp:
> +        (WebCore::ResourceHandle::defaultSession):
> +

Typically we fill these out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.