[Webkit-unassigned] [Bug 64143] Page-Up or Page-Down inside textarea scrolls not just its content but the page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64143


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100455|review?                     |review-
               Flag|                            |




--- Comment #13 from Kent Tamura <tkent at chromium.org>  2011-07-12 03:13:43 PST ---
(From update of attachment 100455)
View in context: https://bugs.webkit.org/attachment.cgi?id=100455&action=review

I'm not familiar with RenderLayer and I won't set r+, but I have some comments.

> LayoutTests/ChangeLog:15
> +
> +        * editing/input/pageup-and-pagedown-in-textarea-expected.txt: Added.
> +        * editing/input/pageup-and-pagedown-in-textarea.html: Added.
> +

The file list is out-of-sync.  You updated other files.

> LayoutTests/editing/input/pageup-and-pagedown-in-textarea-expected.txt:33
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.
> +Many many lines here.

These lines are meaningless.  Please remove them before the test completion.

> LayoutTests/editing/input/pageup-and-pagedown-in-textarea.html:76
> +}

Please show something if there is no layoutTestController.
If we can test manually on a browser, show manual test instructions. Otherwise, show an excuse message about the requirement of layoutTestController.

> LayoutTests/platform/chromium-win/fast/layers/scroll-rect-to-visible-expected.txt:-62
>          text run at (0,0) width 11: "A"
> -scrolled to 0,13

You updated a text expectation for chromium-win but not updated an image expectation. So this will break Chromium-win buidbots.
Please add this test to LayoutTests/platform/chromium/test_expectations.txt to avoid the breakage.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.