[Webkit-unassigned] [Bug 64342] New: Simplify logic in ResourceResponse::nsURLResponse

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64342

           Summary: Simplify logic in ResourceResponse::nsURLResponse
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: psolanki at apple.com
                CC: ddkilzer at webkit.org, jberlin at webkit.org


In the review for the fix for bug 63286, David Kilzer notes <https://bugs.webkit.org/show_bug.cgi?id=63286#c5>

> Is there ever a case where you have an m_nsResponse but not a m_cfResponse (in which case you could
> make the m_cfResponse from the m_nsResponse)?  Or is this ASSERT-ed elsewhere during construction
> so it's not possible to get into this state?
> 
> Could some of this logic be simplified by doing an early return if m_isNull is true:
>
>    if (m_isNull)
>        return nil;

IIRC the code is a bit convoluted due to some layout test failures I had run into. But we should revisit it. I think it can be simplified.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.