[Webkit-unassigned] [Bug 62840] Optimize HTMLInputElement::updateCheckedRadioButtons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62840





--- Comment #11 from Kent Tamura <tkent at chromium.org>  2011-07-11 21:24:01 PST ---
(In reply to comment #9)
> Created an attachment (id=100433)
 --> (https://bugs.webkit.org/attachment.cgi?id=100433&action=review) [details]
> new patch
> 
> Many thanks for helping review the patch and the good comments:)
> 
> 1)I have changed 'if(type()!=(InputTypeNames::checkbox()))' to 'if(type()==(InputTypeNames::radio()))', but I'm sorry that I'm not sure that besides 'radio', we don't need to call updateCheckedRadioButtons() for all the other types of input element?

Please change it to 'if (isRadioButton())'.  Using string type() is inefficient and strange.
updateCheckedRadioButtons() is necessary only for radio buttons.

> 2)The next attachement is the micro-benchmark I use to test the page loading performance, run "./chrome --allow-file-access-from-files omedia_workload4_iterations_rev5x5.html" to get the result, and the result shows that Chromium(build 91994) w/ patch ~1.3x faster to load page radio.html(heavily using 'radio').

Thank you for the test!
1.3x is a little disappointing. Anyway let's go ahead with this approach, and we should work on further improvement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.