[Webkit-unassigned] [Bug 62536] [EFL] Supports to execute "redo" command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62536


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at samsung.com




--- Comment #21 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-07-11 20:33:29 PST ---
(In reply to comment #20)
> (From update of attachment 100375 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100375&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:214
> > +        ASSERT(!m_isInRedo);
> > +        m_isInRedo = true;
> 
> I'm still not happy about the fact there's asymmetry between undo and redo.

It looks the m_isInRedo flag is used by registerCommandForUndo() in GTK port.

http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp#L354

So, if we don't know why redoStack is cleared when m_isInRedo is false, we should not add the m_isInRedo to redo().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.