[Webkit-unassigned] [Bug 63481] Bring V8's SerializedScriptValue implementation up to date

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 15:02:19 PDT 2011


--- Comment #10 from Dmitry Lomov <dslomov at google.com>  2011-07-11 15:02:19 PST ---
(In reply to comment #9)

> Concerning the changes to DOMException: I'm looking at http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#exception-domexception which includes these missing enumeration values. Leaving the other two out in particular would leave weird holes in ExceptionCode.cpp. The constants in ExceptionCode.h were removed after I consulted with Jian Li (they were getting in the way of constants I needed to define).

It is not a big deal, but here is what I think - this set of exception codes is still an unapproved draft. If you add an exception code that you are not using and which is unrelated to cloning patch, and that exception code later changes, and somebody will be working on those changes, there will be some puzzlement and investigation - why this exception code is added? who uses it?  So I am arguing for just adding what you use. At the very least, add a comment saying that exception codes are unused and you are just adding them for completeness.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list