[Webkit-unassigned] [Bug 64135] [NRWT] Doesn't create a link in /tmp/LayoutTests causing tests to fail

Mon Jul 11 14:31:13 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=64135

Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpranke at chromium.org

--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2011-07-11 14:31:13 PST ---
Ugh. I wonder why we haven't seen the mac NRWT port failling this test more often.

Adam already R-'ed this, but at any rate, this is the wrong way to work around this. The top-level run_webkit_tests.py script is just a wrapper around controllers/manager.py which does all the real work. 

Assuming we did want NRWT to hack this, we should create the link (if it doesn't already exist) in manager.py:824 set_up_run(), and remove the link (if and only if we created it) in clean_up_run() in 951.

However, we really shouldn't have to be doing this at all, and NRWT shouldn't need to be aware of this. Chromium, for example, is smart enough to dynamically remap this in pathToLocalResource(), and the other ports probably should be as well.

Can you file a separate bug to get the DRT's fixed if we can't just fix the tests?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.