[Webkit-unassigned] [Bug 63674] Get webkit to compile with USE(CFNETWORK) enabled on Mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 11:39:50 PDT 2011


--- Comment #6 from Jessie Berlin <jberlin at webkit.org>  2011-07-11 11:39:49 PST ---
(From update of attachment 99199)
View in context: https://bugs.webkit.org/attachment.cgi?id=99199&action=review

This patch seems to cover a couple different things. The CookieStorage, RunLoop, Downloads and Authentications changes all seem pretty separate. Since I am not familiar with Downloads / Auth, I feel a little bit uncomfortable unofficially reviewing that code.

> Source/WebCore/platform/mac/WebCoreSystemInterface.h:342
> +

No need for this extra line.

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:72
> +    return wkGetDefaultHTTPCookieStorage();

This will be wrong for Windows WK2.

On Windows WK2, it needs to return the cookie storage for the storage session that is shared between the UI and Web Processes.

Instead of returning wkGetDefaultHTTPCookieStorage(), you should return defaultCookieStorage() like the original version of the method does, and move defaultCookieStorage out of the Windows-only code section.

> Source/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm:188
>      [authenticationChallenge.sender() useCredential:mac(credential) forAuthenticationChallenge:authenticationChallenge.nsURLAuthenticationChallenge()];

Is this going to be handled somewhere else for the CFNetwork on Mac version?

> Source/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm:195
>      [authenticationChallenge.sender() continueWithoutCredentialForAuthenticationChallenge:authenticationChallenge.nsURLAuthenticationChallenge()];


> Source/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm:202
>      [authenticationChallenge.sender() cancelAuthenticationChallenge:authenticationChallenge.nsURLAuthenticationChallenge()];


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list