[Webkit-unassigned] [Bug 62536] [EFL] Supports to execute "redo" command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62536





--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2011-07-11 09:22:33 PST ---
(From update of attachment 100249)
View in context: https://bugs.webkit.org/attachment.cgi?id=100249&action=review

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:203
> +        RefPtr<WebCore::EditCommand> command(undoStack.takeFirst());

Nit: I think we normally use assignment operator here.

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:211
> +        RefPtr<WebCore::EditCommand> command(redoStack.takeFirst());

Ditto.

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:214
> +        ASSERT(!m_isInRedo);
> +        m_isInRedo = true;

Do we really need to do this?  We don't do this for undo, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.