[Webkit-unassigned] [Bug 62935] [GTK] Fix GTK unit tests failures when WebKit is build outside repository directory.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62935


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98142|review?                     |review-
               Flag|                            |




--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2011-07-11 07:55:40 PST ---
(From update of attachment 98142)
View in context: https://bugs.webkit.org/attachment.cgi?id=98142&action=review

> Source/WebKit/gtk/tests/test_utils.c:34
> +    /* user can set location of the webkit repository directory if it differs from build directory */
> +    const char* repo_path = g_getenv("WEBKITREPODIR");
> +    if (repo_path) {
> +        if (g_chdir(repo_path)) {
> +	    return -1;
> +	}
> +    }
> +    else if (g_path_is_absolute(executable_path)) {

Indentation seems quite off here, or is it the patch viewer? The inner if should not have bracers (this file has plenty of this problem, unfortunately), and the else if should be in the same line as the }. Also, given this is a C file, the * should be on the right side. What do you think of doing a style cleanup on this file? ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.