[Webkit-unassigned] [Bug 64262] Small speed up, which switches some virtual functions to inline ones.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 06:45:36 PDT 2011


Gabor Loki <loki at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |hyatt at apple.com

--- Comment #6 from Gabor Loki <loki at webkit.org>  2011-07-11 06:45:35 PST ---
> >      virtual IntSize fixedSize(const RenderObject*) { return IntSize(); }

I guess you wanted to point to 'virtual bool isFixedSize() const { return false; }' line. ;)

> Such function must remain virtal, as it can be called from its base class (if exists), or from its descendants. I would not overwrite them except if we got a permission from the author of those functions, and done them one-by-one.
> There are several others like this.

Well, this code is 3 years old. Since then there were no attempt to introduce new descendant or to extend this virtual function. So, I do not expect this patch will crash a rapidly changing API. However, we can ask the author about this code.

David, what do you think about Tamas's change?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list