[Webkit-unassigned] [Bug 64259] [EFL] Implement EditorClientEfl::respondToChangedContents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64259


Raphael Kubo da Costa <kubo at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kubo at profusion.mobi




--- Comment #4 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-07-11 06:05:46 PST ---
Informal r- to address these small issues:

LGTM in general, however I think these new signals should be documented in ewk_frame.h and ewk_view.h even though the functions which emit them are marked as internal, as the signals are emitted publicly anyway.

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:125
> +    Evas_Object* frame = ewk_view_frame_focused_get(m_view);

Doing it like this should make the code a bit shorter:

  Evas_Object* frame = ewk_view_frame_focused_get(m_view) ? ewk_view_frame_focused_get(m_view) : ewk_view_frame_main_get(m_view);

> Source/WebKit/efl/ewk/ewk_private.h:115
> +void ewk_view_editor_client_contents_changed(Evas_Object* o);

Nitpick: this declaration could come before the one above it so that they are sorted alphabetically.

> Source/WebKit/efl/ewk/ewk_private.h:184
> +void ewk_frame_editor_client_contents_changed(Evas_Object* o);

Nitpick: this declaration could come before the one above it so that they are sorted alphabetically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.