[Webkit-unassigned] [Bug 63317] Web Inspector: console.markTimeline vs. console.timeStamp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63317


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100215|review?                     |review-
               Flag|                            |




--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2011-07-11 02:31:46 PST ---
(From update of attachment 100215)
View in context: https://bugs.webkit.org/attachment.cgi?id=100215&action=review

One comment, otherwise looks good.

> Source/WebCore/page/Console.cpp:258
> +    String consoleMessage = "console.markTimeline() is deprecated. Please use console.timeStamp() instead.\n";

I can see Closure JS library using this method, I can also see a couple of production web apps using it (Google Maps, GMail, etc.). Extensive console logging will affect site performance, so I'd rather:

- make it silently delegate to timeStamp here
- deprecate it in all the docs possible
- fix Closure and suggest Maps and Gmail migrating to the new solution (they will benefit via Firebug support).

Then we will be able to either put logging here or nuke the method altogether.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.