[Webkit-unassigned] [Bug 62536] [EFL] Supports to execute "redo" command.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 00:05:55 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62536





--- Comment #15 from Jaehun Lim <ljaehun.lim at samsung.com>  2011-07-11 00:05:55 PST ---
(In reply to comment #13)
> (From update of attachment 97375 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97375&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:157
> > -    notImplemented();
> > +    redoStack.append(command);
> 
> Why don't you prepend here instead?
> 
> > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:190
> > +        RefPtr<WebCore::EditCommand> command(*(--undoStack.end()));
> > +        undoStack.remove(--undoStack.end());
> 
> so that you can use undoStack.first() and undoStack.removeFirst() here instead.

I applied your comments. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list