[Webkit-unassigned] [Bug 61528] Implement maxWidth check for canvas fill/strokeText

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61528





--- Comment #15 from Philip Rogers <pdr at google.com>  2011-07-09 12:45:54 PST ---
(In reply to comment #13)
> Woops, didn't finish that reply - changing the bug title also submitted my text!
> 
> James, I'm guessing your previous comment was from reading the previous title for this bug? I updated the title for what the patch is here.

Thanks for updating the title

> His fix implements maxWidth for text drawing which fixes (2d.text.draw.fill.maxWidth.fontface.html) and those standalone tests philip (Taylor) has.
> 
> Philip Rogers (what's your IRC? probably easier to refer to you that way), could you rework those tests you added to have the canvas show only green (all over) on success? I imagine just having that super big "I" cover all the red canvas if it's green if it's supposed to be visible AND a totally green canvas that isn't covered by a big red "I" if the text drawn isn't visible (because of the width limitations). Does that make sense?
> 
> Also, keep in mind that each platform will draw that "I" a little differently, so either make it overly large or see if you can use the Ahem font (via context.font) to just draw squares. I'm not sure if I've used non-standard fonts on a canvas before, but looking at the spec quickly it sounds like you should be able to.

It's unfortunate Philip and I have the same name! Feel free to call me pdr or pdr2 (my irc nick)

I reworked the tests to use the Ahem font as you suggested. I was hoping to avoid using Ahem because there's some trickiness around getting the fonts to load before using them, but I think we have a much cleaner set of tests now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.