[Webkit-unassigned] [Bug 64177] ApplicationCache update should not immediately fail when reaching per-origin quota

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64177





--- Comment #12 from Joseph Pecoraro <joepeck at webkit.org>  2011-07-08 18:10:54 PST ---
(In reply to comment #11)
> (From update of attachment 100181 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100181&action=review
> 
> I haven't been able to follow the new logic in ApplicationCacheGroup::checkIfLoadIsComplete(). I'd like to fully understand it, and will get back to it on Monday.
> 
> > Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:615
> >          cacheUpdateFailedDueToOriginQuota();
> > +        cacheUpdateFailed();
> 
> It's super confusing to have two "failed" calls, which do completely different things.
> 
> In fact, we should log different messages when the function is called for early abort here, and when it's called after full update.

I can remove the cacheUpdateFailedDueToOriginQuota function and
instead pull its 1 or 2 lines out to the call sites.


> > Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:937
> > +                // We ran out of space for this origin. Fall down to the normal error handling
> > +                // after recording this state.
> >                  cacheUpdateFailedDueToOriginQuota();
> 
> We should log cache size and quota size in this case (and possibly the size of other caches for this origin).

Can we leave that for a follow-up bug or would you like me to tackle that now?


> > Source/WebCore/page/ChromeClient.h:196
> > +        virtual void reachedApplicationCacheOriginQuota(SecurityOrigin*, int64_t spaceNeeded) = 0;
> 
> It's not 100% clear if spaceNeeded is total space needed, or how much more space we need in addition to what we have.

It is total space needed. I could improve the function's documentation and
rename the parameter to totalSpaceNeeded or something else.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.