[Webkit-unassigned] [Bug 44759] [EFL] Add custom network resource handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44759





--- Comment #25 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2011-07-08 11:52:09 PST ---
Hi Martin,

I'm the one that created this port (based on an initial try, but I almost rewrote it) and as I'm a core EFL developer, I followed EFL style for EFL related parts (ie: C parts). So Flavio is on the right path, including EFL convention of short-descriptive names if the scope is narrow (such as "ret").

I believe it is fair to have Flavio to change comments to be finished with a trailing period and to use C++ casts instead of traditional C (although I'm used to the later and so there are couple of them in our code).

The "//" in C header file won't matter as EFL uses it as well, so if one have EFL installed (required by this port) he will have a compiler that works with that ;-)

Last but not least I believe the "const char **" cast is required due: http://c-faq.com/ansi/constmismatch.html but worth checking.

All in all I'd give an informal "r+" after the minor issues are fixed (trailing ".", c++ casts)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.