[Webkit-unassigned] [Bug 37674] Implement sizes attribute for link tag from HTML5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37674





--- Comment #9 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-07-08 09:35:21 PST ---
(In reply to comment #8)
> (From update of attachment 100048 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100048&action=review
> 
> >> Source/WebCore/ChangeLog:8
> >> +        No new tests. (OOPS!)
> > 
> > This won't let you land. You probably need to explain why there are no new tests for the code you adding.
> 
> There are no new tests because no observable WebKit behavior changed.
> 
> This patch simply adds a new API that allows UA's to retrieve a full list of <link rel=icon> elements encountered. The strategy for picking or downloading favicons has not been affected at all. (Deliberately left out - see bug for add'l comments)

If we're adding code, we should ensure it's tested somehow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.