[Webkit-unassigned] [Bug 64059] REGRESSION (r88913): Preview in Safari’s snippet editor has a fixed height instead of filling the entire pane

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64059





--- Comment #5 from Nikolas Zimmermann <zimmermann at kde.org>  2011-07-08 04:44:16 PST ---
(In reply to comment #4)
> I believe you’re looking for logic along the lines of what RenderBox::computePercentageLogicalHeight() does, namely:
> 
> 
>     // A positioned element that specified both top/bottom or that specifies height should be treated as though it has a height
>     // explicitly specified that can be used for any percentage computations.
>     // FIXME: We can't just check top/bottom here.
>     // https://bugs.webkit.org/show_bug.cgi?id=46500
>     bool isPositionedWithSpecifiedHeight = cb->isPositioned() && (!cb->style()->logicalHeight().isAuto() || (!cb->style()->top().isAuto() && !cb->style()->bottom().isAuto()));

Superb! I'm going to prepare a patch!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.