[Webkit-unassigned] [Bug 62840] Optimize HTMLInputElement::updateCheckedRadioButtons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62840


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tkent at chromium.org




--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-07-07 20:21:40 PST ---
(In reply to comment #1)
> And, in my opinion, we may do not need to call updateCheckedRadioButtons() for checkbox in fact, it was just need for 'radio' type. So, I think we may can use 'if Statement' to avoid the unnecessary call for checkbox to remove the traversal overhead.

Indeed. We don't need to call updateCheckedRadioButtons() for checkboxes.

> Of cause, I think in the future we may need to improve the algorithm of updateCheckedRadioButtons(), like to add a structure to save all the input elements' name and type, then we don't have to traverse the whole document:).

Document::m_formElementsWithState contains all of checkboxes and radio buttons in the document. Searching it for buttons would improve the performance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.