[Webkit-unassigned] [Bug 64127] Committer for r90588 is commit-queue at webkit.org, but should have been abarth at webkit.org

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 14:35:55 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64127





--- Comment #1 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-07 14:35:55 PST ---
Here's how this is supposed to work:

1) When the commit-queue commits the patch, it runs commit-log-editor to generate the commit message. (This happens in the bowels of webkitpy.)
2) commit-log-editor, upon seeing that the patch author (abarth at webkit.org) and committer (commit-queue at webkit.org) are not the same, inserts a "Patch by Adam Barth <abarth at webkit.org>" line into the commit message
3) When the commit occurs, a script on svn.webkit.org scans the commit message, sees the "Patch by" line, removes it, and sets abarth at webkit.org as the committer for that change.

Something went wrong in this sequence. We already have confirmation from Bill Siegrist that the original commit message did not include the "Patch by" line. So the bug is not with (3). It might be with (1) or (2). Most likely (2).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list