[Webkit-unassigned] [Bug 39578] [Qt] IME: no underline is shown when entering Japanese preedit text in an input box on QtWebKit ( browser.exe )

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39578





--- Comment #10 from Benjamin Poulain <benjamin at webkit.org>  2011-07-07 14:30:02 PST ---
(From update of attachment 99267)
View in context: https://bugs.webkit.org/attachment.cgi?id=99267&action=review

You do not explain how this patch solve the original problem. I wonder if we can solve the bug without the save()/restore().

The change looks sane but I am not convinced that is the best solution. Saving and restoring state is not cheap. In the general usage of RenderObject::drawLineForBoxSide(), the state varies actually very little between calls so the rendering is effective even on OpenGL graphic system.

> Source/WebCore/ChangeLog:13
> +        No new tests. (OOPS!)
> +

This should not be in the changelog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.