[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26755





--- Comment #45 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-07 11:55:53 PST ---
(In reply to comment #43)
> > Both MockExecutive and MockExecutive2 just return canned output. Is that really what we want?
> 
> For most tests, yes.  If you specifically want to test integration with commit-log-editor, we can do that by explicitly passing a live Executive in the test.  Generally, we avoid unit tests that touch the real disk or spawn processes whenever possible.  We have a handful to make sure we continue to integrate correctly with external dependencies, but we don't need to test commit-log-editor exhaustively in test-webkitpy (we should just test that it works at all).

I think it makes sense to test the integration with commit-log-editor here. So here's my plan:

1) Make Checkout use SCM's Executive instance instead of conjuring one out of thin air
2) Make the mock SCM I create in the test use a real Executive instance

I'll file a new bug for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.