[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 11:07:29 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=26755





--- Comment #42 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-07 11:07:28 PST ---
(In reply to comment #41)
> > MockExecutive seems to be part of the tool module. Is it really OK to use that in code inside the common module?
> 
> MockExecutive should move into the common module.  If you don't want to do that in this patch, there's already MockExecutive2 in the common package, which is helpful for some kinds of tests.  (I'm not entirely sure why we have two kinds of MockExecutives.)

Both MockExecutive and MockExecutive2 just return canned output. Is that really what we want?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list