[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26755





--- Comment #40 from Adam Barth <abarth at webkit.org>  2011-07-07 11:03:51 PST ---
> Note also that other code in this module uses the standalone run_command() function. I used Executive().run_command() because run_command() says to do that.

That code is also wrong.  :)

The code that calls the standalone run_command() function all dates from the beginning of webkitpy, before we had any testing and before we re-designed for testing.  Eventually we'll clean up this code to follow the same invariants as the rest of webkitpy, but that's not been a super high priority.

That said, we don't want to spread this bad pattern to more locations, and when touching any code with the bad pattern, we usually update it to be more modern.  I certainly understand why you wrote the patch the way you did.  This sort of thing is supposed to be flagged in the review process.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.