[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26755





--- Comment #37 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-07 10:55:20 PST ---
(From update of attachment 99987)
View in context: https://bugs.webkit.org/attachment.cgi?id=99987&action=review

>>> Tools/Scripts/webkitpy/common/checkout/checkout.py:123
>>> +        message_text = Executive().run_command([self._scm.script_path('commit-log-editor'), '--print-log'] + changelog_paths, return_stderr=False)
>> 
>> This isn't correct.  You need to get the executive from the tool so that it is mocked out correctly in unit tests.
> 
> This code is below the level of the tool. Using it here would be a layering violation, I believe. How do you suggest we make this work?

Note also that other code in this module uses the standalone run_command() function. I used Executive().run_command() because run_command() says to do that.

>> Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py:85
>> +    expected_commit_message = u"""Unreviewed build fix to un-break webkit-patch land.
> 
> Some of these intentionally contained unicode.  Do we still correctly support unicode commit messages?

We do. I filed bug 64109 to prove it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.