[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 10:49:09 PDT 2011


--- Comment #34 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-07 10:49:08 PST ---
(From update of attachment 99987)
View in context: https://bugs.webkit.org/attachment.cgi?id=99987&action=review

>> Tools/Scripts/webkitpy/common/checkout/checkout.py:123
>> +        message_text = Executive().run_command([self._scm.script_path('commit-log-editor'), '--print-log'] + changelog_paths, return_stderr=False)
> This isn't correct.  You need to get the executive from the tool so that it is mocked out correctly in unit tests.

This code is below the level of the tool. Using it here would be a layering violation, I believe. How do you suggest we make this work?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list