[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26755


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99985|review?                     |review+
               Flag|                            |




--- Comment #26 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-07-07 09:06:12 PST ---
(From update of attachment 99985)
View in context: https://bugs.webkit.org/attachment.cgi?id=99985&action=review

r=me, although consider fixing the exit issues.

> Tools/Scripts/commit-log-editor:50
>  sub usage

Consider renaming to printUsageAndExit() so it's more descriptive.

> Tools/Scripts/commit-log-editor:73
> +    exit !$getOptionsResult;

This exit doesn't do anything because usage() already exits.

> Tools/Scripts/commit-log-editor:81
> +        exit 1;

Ditto.

> Tools/Scripts/commit-log-editor:84
> +    exit;

"exit 0;" ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.